On 27.07.20 15:35, Tom Rini wrote: > On Mon, Jul 27, 2020 at 02:49:30PM +0200, Stefano Babic wrote: >> Hi Igor, >> >> On 15.07.20 12:30, Igor Opaniuk wrote: >>> From: Igor Opaniuk <[email protected]> >>> >>> These functions wrap functionality for storing config blocks in EEPROM. >>> >>> Signed-off-by: Igor Opaniuk <[email protected]> >>> --- >>> >> >> This breaks one of your (obsolete ?) board, colibri_pxa270 >> >> Reason is a side-effect in dm/read.h: >> >> arm: + colibri_pxa270 >> +In file included from include/dm.h:12, >> + from board/toradex/common/tdx-eeprom.c:6: >> +include/dm/read.h: In function 'dev_read_alias_seq': >> +include/dm/read.h:932:10: error: 'ENOTSUPP' undeclared (first use in >> this function) >> + 932 | return -ENOTSUPP; >> + | ^~~~~~~~ >> +include/dm/read.h:932:10: note: each undeclared identifier is reported >> only once for each function it appears in >> +make[2]: *** [scripts/Makefile.build:266: >> board/toradex/common/tdx-eeprom.o] Error 1 >> +make[1]: *** [Makefile:1793: board/toradex/common] Error 2 >> +make: *** [Makefile:167: sub-make] Error 2 >> >> >> Adding the include to dm/read.h, issue is solved: >> >> diff --git a/include/dm/read.h b/include/dm/read.h >> index f02ec95954..cc4ab22f65 100644 >> --- a/include/dm/read.h >> +++ b/include/dm/read.h >> @@ -12,6 +12,7 @@ >> #include <dm/fdtaddr.h> >> #include <dm/ofnode.h> >> #include <dm/uclass.h> >> +#include <linux/errno.h> >> >> struct resource; >> >> >> I could add it myself if there is a general agreement, but the usual way >> is to repost it. > > This is also fixed by: > http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/ > as Dan also ran in to this problem. I assigned it to Simon but if you > want to take it as part of being able to pick up Igor's series now I'm > sure that's fine. Thanks!
Fine, thanks ! I pick up Dan's. Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
