Hi Rayagonda, On Thu, 23 Jul 2020 at 06:01, Rayagonda Kokatanur <[email protected]> wrote: > > From: Corneliu Doban <[email protected]> > > Add eMMC and GPT support. > - GPT partition list and command to create the GPT added to u-boot > environment > - eMMC boot commands added to u-boot environment > - new gpt commands (enumarate and setenv) that are used by broadcom > update scripts and boot commands > - eMMC specific u-boot configurations with environment saved in eMMC > and GPT support > > Signed-off-by: Corneliu Doban <[email protected]> > Signed-off-by: Rayagonda Kokatanur <[email protected]> > --- > Changes from v3: > -Address review comments from Simon Glass, > Return -ve number instead of 1 upon failure, > Use shorter variable name, > Modified code to avoid buffer overflow, > Use if (!strcmp(...)) instead of if (strcmp(...) == 0) > > Changes from v2: > -Address review comments from Simon Glass, > Check for return value of part_driver_get_count(), > Don't check return value of part_driver_get(), > Rewrite part_driver_get() and rename to part_driver_get_first(), > Use env_set_ulong() whereever applicable, > > -Address review comments from Michael Nazzareno Trimarchi, > Add new function to set all env vriables, > > Changes from v1: > -Address review comments from Simon Glass, > Correct function comments, > Check for return value, > Add helper function in part.h > > cmd/gpt.c | 161 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/part.h | 29 +++++++++ > 2 files changed, 190 insertions(+)
Yes this looks OK to me. What sort of trouble are you having with the test? Regards, SImon
