Hi Stefan, On Fri, 24 Jul 2020 at 04:09, Stefan Roese <s...@denx.de> wrote: > > From: Suneel Garapati <sgarap...@marvell.com> > > For platforms with multiple slot support like OcteonTX, > this is invoked per slot. > > Signed-off-by: Suneel Garapati <sgarap...@marvell.com> > Cc: Peng Fan <peng....@nxp.com> > > Signed-off-by: Stefan Roese <s...@denx.de> > --- > > Changes in v1: > - Change patch subject > > drivers/mmc/mmc.c | 2 +- > include/mmc.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index f36d11ddc8..b26df59b91 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -2683,7 +2683,7 @@ __weak void board_mmc_power_init(void) > } > #endif > > -static int mmc_power_init(struct mmc *mmc) > +int mmc_power_init(struct mmc *mmc)
Shouldn't multi-slot be a core MMC featuren then? > { > #if CONFIG_IS_ENABLED(DM_MMC) > #if CONFIG_IS_ENABLED(DM_REGULATOR) > diff --git a/include/mmc.h b/include/mmc.h > index 82562193cc..e05c59713c 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -747,6 +747,7 @@ int mmc_unbind(struct udevice *dev); > int mmc_initialize(struct bd_info *bis); > int mmc_init_device(int num); > int mmc_init(struct mmc *mmc); > +int mmc_power_init(struct mmc *mmc); This badly needs a comment to explain what it is for and when to call it. > int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error); > > #if CONFIG_IS_ENABLED(MMC_UHS_SUPPORT) || \ > -- > 2.27.0 > Regards, Simon