Hi Kever, On Sat, 8 Aug 2020 at 04:59, Kever Yang <[email protected]> wrote: > > Hi Simon, > > 在 2020/7/20 上午3:55, Simon Glass 写道: > > Bob is a Chromebook and can boot from SPI flash. Add it to the condition > > check for this. > > > > Signed-off-by: Simon Glass <[email protected]> > > --- > > > > (no changes since v1) > > > > arch/arm/mach-rockchip/spl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c > > index cddf4fd3d5..f148d48b6a 100644 > > --- a/arch/arm/mach-rockchip/spl.c > > +++ b/arch/arm/mach-rockchip/spl.c > > @@ -54,7 +54,8 @@ u32 spl_boot_device(void) > > #if defined(CONFIG_TARGET_CHROMEBOOK_JERRY) || \ > > defined(CONFIG_TARGET_CHROMEBIT_MICKEY) || \ > > defined(CONFIG_TARGET_CHROMEBOOK_MINNIE) || \ > > - defined(CONFIG_TARGET_CHROMEBOOK_SPEEDY) > > + defined(CONFIG_TARGET_CHROMEBOOK_SPEEDY) || \ > > + defined(CONFIG_TARGET_CHROMEBOOK_BOB) > > Can we use "u-boot,spl-boot-order" in dts instead of hardcode define here?
Yes that sounds better. Will take a look. Regards, Simon
