Dear Scott Wood, In message <20100920111852.0cc76...@udp111988uds.am.freescale.net> you wrote: > > > ifndef TEXT_BASE > > > TEXT_BASE = 0xFC000000 > > > endif > > > > Why? > > It might have been already set to something else by nand_spl or > similar.
No. There is no NAND on that board. > > > no assignments in if statements. > > > > Why? > > It could just as easily, and more readably, be written as: > > rv = cpu_eth_init(bis); > if (rv >= 0) > ... It depends whether you call that more readable. The UNIX code where I learned C was full of that, and I find it actually easier to read. > FWIW, Linux's checkpatch.pl looks for this and calls it an error, and > U-Boot says it follows Linux coding style. OK, that's an argument. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The value of marriage is not that adults produce children, but that children produce adults." - Peter De Vries _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
