On Sat, 12 Sep 2020 at 15:46, Sean Anderson <[email protected]> wrote: > > net_init does not always succeed, and there is no existing mechanism to > discover errors. This patch allows callers of net_init (such as net_init) > to handle errors. The root issue is that eth_get_dev can fail, but > net_init_loop doesn't expose that. The ideal way to fix eth_get_dev would > be to return an error with ERR_PTR, but there are a lot of callers, and all > of them just check if it's NULL. Another approach would be to change the > signature to something like > > int eth_get_dev(struct udevice **pdev) > > but that would require rewriting all of the many callers. > > Signed-off-by: Sean Anderson <[email protected]> > --- > > include/net.h | 2 +- > net/eth-uclass.c | 3 +++ > net/net.c | 15 +++++++++++---- > 3 files changed, 15 insertions(+), 5 deletions(-)
Reviewed-by: Simon Glass <[email protected]>
