On Fri, Sep 18, 2020 at 07:14:02PM +0200, Heinrich Schuchardt wrote: > On 9/18/20 1:28 PM, Tom Rini wrote: > > On Fri, Sep 18, 2020 at 06:07:42AM +0200, Heinrich Schuchardt wrote: > >> Am 17. September 2020 20:53:20 MESZ schrieb Tom Rini <[email protected]>: > >>> On Thu, Sep 17, 2020 at 08:03:24PM +0200, Heinrich Schuchardt wrote: > >>>> On 9/17/20 7:47 PM, Tom Rini wrote: > >>>>> On Thu, Sep 17, 2020 at 07:18:08PM +0200, Heinrich Schuchardt > >>> wrote: > >>>>> > >>>>>> CONFIG_EFI_GRUB_ARM32 is only needed for architectures with caches > >>> that are > >>>>>> not managed via CP15 (or for some outdated buggy versions of > >>> GRUB). It > >>>>>> makes more sense to disable the setting per architecture than per > >>> defconfig. > >>>>>> > >>>>>> Move QEMU's CONFIG_EFI_GRUB_ARM32_WORKAROUND=n from defconfig to > >>> Kconfig. > >>>>>> > >>>>>> Signed-off-by: Heinrich Schuchardt <[email protected]> > >>>>>> --- > >>>>>> configs/qemu_arm_defconfig | 1 - > >>>>>> lib/efi_loader/Kconfig | 1 + > >>>>>> 2 files changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> Why? Are we about to move this to be a short list of "default y if > >>> ..." > >>>>> instead? Otherwise no, this is the level of detail that should be > >>> in a > >>>>> defconfig I think and not Kconfig. > >>>>> > >>>> > >>>> Hello Tom, > >>>> > >>>> yes, in the long run I want to turn this into "default y if". But I > >>>> first need to a list of all ARCH_* which have a cache which is not > >>>> controlled via CP15. > >>> > >>> Isn't the bigger problem / list "needs to support old / buggy GRUB" ? > >> > >> There are no operating systems distributing 2021 U-Boot with 2018 GRUB. > > > > Then we should remove default y there after v2020.10 I think, and get > > the distro folks to ack/review that. I don't think there's any cases of > > "SoC doesn't use CP15 for cache" and "SoC uses GRUB". > > How about l2_cache_disable() in arch/arm/mach-kirkwood/cache.c?
What's the board that uses that and where "SoC uses GRUB" comes in to play. What are the board(s) there we're talking about? -- Tom
signature.asc
Description: PGP signature
