On Wed, Sep 23, 2020 at 07:34:59PM +0100, Jack Mitchell wrote: > > On 23/09/2020 19:23, Tom Rini wrote: > > This converts the following to Kconfig: > > CONFIG_WATCHDOG > > CONFIG_WATCHDOG_TIMEOUT > > CONFIG_WDT > > CONFIG_HW_WATCHDOG > > CONFIG_DESIGNWARE_WATCHDOG > > > > Signed-off-by: Tom Rini <[email protected]> > > Before setting this in stone, after much recent personal confusion > around the watchdog in u-boot, would it be worth considoring changing > CONFIG_WATCHDOG to CONFIG_SW_WATCHDOG, then changing the other options > as appropriate. > > I say this as everytime I come back to enabling watchdog support on a > new board, I always start with CONFIG_WATCHDOG to then find I actually > don't need CONFIG_WATCHDOG but CONFIG_WDT + CONFIG_HW_WATCHDOG. It just > feels like 3 settings saying the same thing when you're grepping the > code to get a grasp on what support to enable. > > Slightly off topic, but I then get even more confused around which > option is DM enabled and which isn't, it doesn't seem to have a sensible > naming barrier between the options like other subsystems do. > > I realise this is probably going to cause some bikeshedding but if there > is a time to change it, it would be in this series.
I don't disagree with a more consistent set of names. However, this patch right here is just about moving boards that fiddle with a symbol in the config header that you must instead be setting in the defconfig. For example, this drops a "don't build watchdog in SPL" for stratix10 but that wasn't working ever for the board I'm pretty confident and isn't working now, it's got the watchdog in both cases. To me this is patch 1 of any series doing more with watchdog related options as getting everyone consistent makes it harder to convert one of the harder cases wrong. -- Tom
signature.asc
Description: PGP signature
