Hi Alper, On Wed, 23 Sep 2020 at 10:52, Alper Nebi Yasak <[email protected]> wrote: > > The PWM device provided by Chrome OS EC doesn't really support anything > other than setting a relative duty cycle. To support it as a backlight, > this patch makes the PWM period optional in the device tree and pretends > the valid brightness range is its period_ns. > > Signed-off-by: Alper Nebi Yasak <[email protected]> > --- > > drivers/video/pwm_backlight.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-)
This looks OK. But please update the comment for pwm_set_config() to describe the param updates and add a sandbox test to pwm.c Does this affect the devicetree binding? Regards, Simon
