On Wed, Sep 30, 2020 at 07:28:42PM +0530, Pratyush Yadav wrote: > On 24/09/20 10:04AM, Pratyush Yadav wrote: > > Hi, > > > > This series is a re-spin of Jean-Jacques' earlier effort [0], the goal > > of which was to facilitate porting drivers from the Linux kernel. It > > adds the managed API, using the same API as Linux. It also adds support > > for regmap fields. > > > > Jean-Jacques' series added support for custom regmap read/write > > callbacks. The design was argued against by Simon [1]. He argued that > > using the driver model was a better idea instead of the custom > > functions. That would mean slightly more memory usage and a more > > involved change. > > > > The main aim of adding the custom functions is to support the Cadence > > Sierra PHY driver from Linux [2]. The driver's custom functions aren't > > very complicated, so they can be replaced by some simple formatting > > options. So, add the struct regmap_config which contains fields to alter > > the behaviour of the regmap. This includes specifying the size of the > > read/write operations via 'width', specifying the start and size of > > range from code instead of device tree via 'r_start' and 'r_size', and > > specifying a left shift of the register offset before access via > > 'reg_offset_shift'. The driver can't be ported verbatim now, but this > > allows the changes to be very isolated and minimal. > > > > These config options allow us to avoid converting to driver model until > > we really need it. > > > > The Travis CI run can be found at [3]. > > > > [0] > > https://patchwork.ozlabs.org/project/uboot/cover/[email protected]/ > > [1] https://patchwork.ozlabs.org/comment/2426186/ > > [2] > > https://elixir.bootlin.com/linux/latest/source/drivers/phy/cadence/phy-cadence-sierra.c > > [3] https://travis-ci.org/github/prati0100/uboot/builds/729588518 > > Ping. > > Tom, do you have any comments? If not can you please pick this series > up?
I will review this and the gpio/reset APIs for next shortly. -- Tom
signature.asc
Description: PGP signature
