> Subject: Re: [PATCH 1/8] tcpc: Add driver for USB typec port controller (TCPC) > > On 10/12/20 8:23 AM, Peng Fan wrote: > [...] > > board/freescale/common/Kconfig | 6 + > > board/freescale/common/Makefile | 4 + > > board/freescale/common/tcpc.c | 1018 > +++++++++++++++++++++++++++++++ > > board/freescale/common/tcpc.h | 469 ++++++++++++++ > > 4 files changed, 1497 insertions(+) > > create mode 100644 board/freescale/common/tcpc.c create mode > 100644 > > board/freescale/common/tcpc.h > > Shouldn't driver be in drivers/ ?
You mean drivers/usb/typec as kernel? There is no common framework now. Regards, Peng. > > [...] > > > diff --git a/board/freescale/common/tcpc.c > > b/board/freescale/common/tcpc.c new file mode 100644 index > > 0000000000..fb532a3d87 > > --- /dev/null > > +++ b/board/freescale/common/tcpc.c > > @@ -0,0 +1,1018 @@ > > [...] > > > +#ifdef DEBUG > > +#define tcpc_debug_log(port, fmt, args...) tcpc_log(port, fmt, > > +##args) #else #define tcpc_debug_log(port, fmt, args...) #endif > > Use dev_dbg() or pr_debug() or just debug() ? > > [...]
