Dear Wolfgang, On 05/10/10 20:21, Wolfgang Denk wrote: > Dear [email protected], > > In message <[email protected]> you > wrote: >> Originally the Makefile defines CONFIG_ADS5121_REV2 when configuring >> for board mpc5121ads_rev2. The config in include/configs/mpc5121ads.h >> expects a define CONFIG_MPC5121ADS_REV2 for this. >> Therefore there are two defines used but only 1 is defined. >> This patch renames references to CONFIG_ADS5121_REV2 to >> CONFIG_MPC5121ADS_REV2 >> to have one common define. >> >> This patch fixes faulty mem size detection caused by wrong config in >> include/configs/mpc5121ads.h > > Thanks. But... should we not rather drop that code completely? I > guess the number of remaining Rev. 2 boards should be epsilon. Do you > think these veterans are still in use anywhere?
Hehe, well there is at least the one rev 2 board that I got from the customer on my desk at the moment. That's why I tried to build and execute this config. I really can't tell if there are many more around so I'd like to leave it up to the experts if it is necessary to keep the code in. I am really glad though that it still is right now because it would have costed me a considerable amount of time to figure out the differences between the different revs. Best regards, Mark _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
