On 15/01/21 07:04AM, Simon Glass wrote: > This function can be used to get any flags, not just direction flags. > Rename it to avoid confusion. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > drivers/gpio/gpio-uclass.c | 2 +- > include/asm-generic/gpio.h | 4 ++-- > test/dm/gpio.c | 12 ++++++------ > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c > index 83d3cf0a6b3..864a9003245 100644 > --- a/drivers/gpio/gpio-uclass.c > +++ b/drivers/gpio/gpio-uclass.c > @@ -682,7 +682,7 @@ int dm_gpio_set_dir(struct gpio_desc *desc) > return _dm_gpio_update_flags(desc, desc->flags); > } > > -int dm_gpio_get_dir_flags(struct gpio_desc *desc, ulong *flagsp) > +int dm_gpio_get_flags(struct gpio_desc *desc, ulong *flagsp) > { > struct udevice *dev = desc->dev; > int ret, value; > diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h > index 48e042dc44b..5ecb73c138d 100644 > --- a/include/asm-generic/gpio.h > +++ b/include/asm-generic/gpio.h > @@ -685,7 +685,7 @@ int dm_gpio_set_dir(struct gpio_desc *desc); > int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags); > > /** > - * dm_gpio_get_dir_flags() - Get direction flags > + * dm_gpio_get_flags() - Get direction flags
s/Get direction flags/Get flags/ With this fixed, Reviewed-by: Pratyush Yadav <p.ya...@ti.com> -- Regards, Pratyush Yadav Texas Instruments India