Steve Sakoman wrote: > On Fri, Oct 8, 2010 at 9:05 AM, Stefano Babic <[email protected]> wrote: >> Steve Sakoman wrote: >> >>>> I'll revise my patch to add the missing gd->env_valid = 1; and re-test. >>> Hmm . . . looking at env_nand.c I see that it doesn't do gd->env_valid >>> = 1 either, which is probably why I removed it last night. >>> >>> Any idea whether it is actually required? Seems to work fine without it! >> I have understood, it is not required if we call env_import and we >> require to verify the checksum. > > OK, thanks! > > Would you like me to submit the patch or would you like to revise & resubmit?
No problem at all - you can submit your patch, as it seems to me more complete as mine. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
