On Thu, Dec 17, 2020 at 05:19:18PM -0600, Brandon Maier wrote: > If one of the reads fails when importing redundant environments (a > single read failure), the env_flags wouldn't get initialized in > env_import_redund(). If a user then calls saveenv, the new environment > will have the wrong flags value. So on the next load the new environment > will be ignored. > > While debugging this, I also noticed that env/sf.c was not correctly > handling a single read failure, as it would not check the crc before > assigning it to gd->env_addr. > > Having a special error path for when there is a single read failure > seems unnecessary and may lead to future bugs. Instead collapse the > 'single read failure' error to be the same as a 'single crc failure'. > That way env_check_redund() either passes or fails, and if it passes we > are guaranteed to have checked the CRC. > > Signed-off-by: Brandon Maier <[email protected]> > CC: Joe Hershberger <[email protected]> > CC: Wolfgang Denk <[email protected]> > CC: Heiko Schocher <[email protected]>
Sorry for the delay. Looking this over, yes, I think this is correct so: Reviewed-by: Tom Rini <[email protected]> And I'm going to give Joe or Wolfgang or Heiko a little more time to chime in before I apply this in time for v2021.04-rc2. -- Tom
signature.asc
Description: PGP signature
