On 2/11/21 10:58 AM, Patrice CHOTARD wrote:
Hi Marek

On 2/10/21 3:26 PM, Marek Vasut wrote:
On 2/10/21 3:17 PM, Patrice Chotard wrote:
Since commit 8745b9ebccae ("usb: gadget: add super speed support")
ums was no more functional on platform which use dwc2_udc_otg driver.

Remove the speed test in dwc2_gadget_start() to fix it.
Tested on stm32mp157c-ev1 board.

Isn't the speed check correct though ?

I am not sure this speed test is needed.


What is really going on when this fails ?


Since 8745b9ebccae ("usb: gadget: add super speed support"),
driver->speed is now set to USB_SPEED_SUPER in drivers/usb/gadget/composite.c

and this forbids dwc2_udc_otg.c to be registered.

That sounds like a bug in the USB gadget/otg core , no ?

Reply via email to