On Wed, Jan 20, 2021 at 10:46:52AM -0600, Alexandru Gagniuc wrote: > When a desired configuration is not found, conf_node will have a > negative value. Thus the for loop will start at the root "/" node of > the image, print the "/description" property, and stop. > > It appears the intent of the loop was to print the names of the > subnodes under "/configurations". We would need the offset to the > "/configurations" node, which is abstracted by fit_find_config_node(). > > This change agrees that abstracting the node offset is the correct > design, and we shouldn't be parsing the configurations manually. Thus > the loop in spl_fit_get_image_name() is useless. Remove it. > > Signed-off-by: Alexandru Gagniuc <[email protected]> > Reviewed-by: Simon Glass <[email protected]>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
