On Tue, Mar 2, 2021 at 11:43 PM Andre Przywara <[email protected]> wrote: > > At the moment the nvme_get_features() and nvme_set_features() functions > carry a (somewhat misleading) comment about missing cache maintenance. > > As it turns out, nvme_get_features() has no caller at all in the tree, > and nvme_set_features' only user doesn't use a DMA buffer. > > Mention that in the comment, and leave some breadcrumbs for the future, > should those functions attract more users. > > Signed-off-by: Andre Przywara <[email protected]> > --- > Hi, > > just extending the comments as this caused some confusion lately, and to > keep the pointer to the NVMe spec I checked. > > Cheers, > Andre > > drivers/nvme/nvme.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) >
Reviewed-by: Bin Meng <[email protected]>
