Hi Harm, On Mon, 8 Mar 2021 at 09:35, Harm Berntsen <[email protected]> wrote: > > I've just tested this on top of the current master (90964ab5) and this > breaks my board (Kirkwood CPU with MVEBU_GPIO=y and DM_I2C_GPIO=y). > I'll do some debugging to see what goes wrong.
Thank you for that. Once we figure this out we should add a test. > > -----Original Message----- > From: Tom Rini <[email protected]> > To: Heiko Schocher <[email protected]>, Harm Berntsen > <[email protected]> > Cc: Simon Glass <[email protected]>, U-Boot Mailing List > <[email protected]>, Patrick Delaunay <[email protected]> > Subject: Re: [PATCH v5 1/2] gpio: i2c-gpio: Drop use of > dm_gpio_set_dir() > Date: Mon, 08 Mar 2021 08:16:53 -0500 > > On Mon, Mar 08, 2021 at 05:59:45AM +0100, Heiko Schocher wrote: > > Hello Simon, > > > > On 08.03.21 04:45, Simon Glass wrote: > > > This is the only driver that uses this function. Update it to use > > > the > > > alternative which is dm_gpio_set_dir_flags(). > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > --- > > > > > > (no changes since v1) > > > > > > drivers/i2c/i2c-gpio.c | 19 +++++++++---------- > > > 1 file changed, 9 insertions(+), 10 deletions(-) > > > > Reviewed-by: Heiko Schocher <[email protected]> > > The series is at: > https://patchwork.ozlabs.org/project/uboot/list/?series=232639&state=* > and I'd really like to see a tested-by. Harm, are you able to test > this > still since you had to fix this area before? Thanks! Regards, Simon
