Re: [PATCH 5/6] simple-pm-bus: Use -ENOSYS for checking missing system call

[Sean Anderson]

On 3/20/21 11:18 PM, Simon Glass wrote:

We don't need to check -ENOTSUPP since this is not used for this purpose
in U-Boot. Update the code accordingly.

Signed-off-by: Simon Glass <s...@chromium.org>
---

  drivers/core/simple-pm-bus.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/core/simple-pm-bus.c b/drivers/core/simple-pm-bus.c
index 7a18953cba1..1bb0d86e289 100644
--- a/drivers/core/simple-pm-bus.c
+++ b/drivers/core/simple-pm-bus.c
@@ -21,7 +21,7 @@ static int simple_pm_bus_probe(struct udevice *dev)
                return ret;

ret = clk_enable_bulk(bulk);

-       if (ret && ret != -ENOSYS && ret != -ENOTSUPP) {
+       if (ret && ret != -ENOSYS) {
                clk_release_bulk(bulk);
                return ret;
        }
@@ -34,7 +34,7 @@ static int simple_pm_bus_remove(struct udevice *dev)
        struct clk_bulk *bulk = dev_get_priv(dev);

ret = clk_release_bulk(bulk);

-       if (ret && ret != -ENOSYS && ret != -ENOTSUPP)
+       if (ret && ret != -ENOSYS)
                return ret;
        else
                return 0;

Nak. This cannot be removed until all drivers have been converted to use
-ENOSYS.

--Sean