Hi,

On 3/22/21 2:20 PM, Alexandru Gagniuc wrote:
CONFIG_SPL_BSS_START_ADDR is only used on a few mach- linker scripts.
stm32mp1 uses the generic script under arch/arm/cpu/u-boot-spl.lds,
which does not make use of this definition.

The SPL BSS starts in SRAM, right after .text, .rodata, .data, and
.u_boot_list. A very short version of the STM32MP1 memory map is:
   * SYSRAM: 2ffc0000 - 30000000     <- all of SPL is here
   * DRAM:   c0000000+

0xC0200000 is a DRAM address, and has nothing to do with SPL. It is
just very misleading to have it next to CONFIG_SPL_BSS_MAX_SIZE, or to
have it at all.

Signed-off-by: Alexandru Gagniuc <[email protected]>
---
  include/configs/stm32mp1.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
index 7fdb3ffce4..56a70cb584 100644
--- a/include/configs/stm32mp1.h
+++ b/include/configs/stm32mp1.h
@@ -50,7 +50,6 @@
  /* SPL support */
  #ifdef CONFIG_SPL
  /* SPL use DDR */
-#define CONFIG_SPL_BSS_START_ADDR      0xC0200000
  #define CONFIG_SPL_BSS_MAX_SIZE               0x00100000
  #define CONFIG_SYS_SPL_MALLOC_START   0xC0300000
  #define CONFIG_SYS_SPL_MALLOC_SIZE    0x01D00000


Strange but agree and CONFIG_SPL_BSS_MAX_SIZE

can be also removed with previous patch.


Reviewed-by: Patrick Delaunay <[email protected]>

Thanks
Patrick

Reply via email to