On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote:

> Add the DeveloperBox 96boards EE support. This board is also
> known as Socionext SynQuacer E-Series. It contians one "SC2A11"
> SoC, which has 24-cores of arm Cortex-A53, and 4 DDR3 slots,
> 3 PCIe slots (1 4x port and 2 1x ports which are expanded via
> PCIe bridge chip), 2 USB 3.0 ports and 2 USB 2.0 ports, 2 SATA
> ports and 1 GbE, 64MB NOR flash and 8GB eMMC on standard
> MicroATX Form Factor.
> 
> For more information, see this page;
>   https://www.96boards.org/product/developerbox/
> 
> Signed-off-by: Masami Hiramatsu <masami.hirama...@linaro.org>
[snip]
> diff --git a/arch/arm/include/asm/arch-sc2a11/gpio.h 
> b/arch/arm/include/asm/arch-sc2a11/gpio.h
> new file mode 100644
> index 0000000000..6779803080
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-sc2a11/gpio.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2021 (C) Linaro Ltd.
> + */
> +
> +#ifndef __ASM_ARCH_SC2A11_GPIO_H
> +#define __ASM_ARCH_SC2A11_GPIO_H
> +
> +#endif

Please update the list in arch/arm/include/asm/gpio.h to not look for
asm/arch/gpio.h on this SoC, thanks.

> diff --git a/board/socionext/developerbox/README 
> b/board/socionext/developerbox/README
> new file mode 100644
> index 0000000000..bb121002dd
> --- /dev/null
> +++ b/board/socionext/developerbox/README

This needs to be in rST form and under doc/board/ now.

[snip]
> +/*
> + * arguments for booti command
> + */
> +#define LINUX_BASIC_BOOTARGS "basic_bootargs='"                              
>         \
> +                             "console=ttyAMA0," __stringify(CONFIG_BAUDRATE) 
> " "     \
> +                             "rootwait verbose'\0"
> +
> +/* kernel:mmcblk0p1(ext2), rootfs:mmcblk0p1(ext2), devtree:mmcblk0p1(ext2) */
> +#define      LINUX_MMCBOOTCOMMAND1                                           
>         \
> +     "mmcboot1=echo 'Boot from MMC (ext2 single rootfs)' ; "                 
> \
> +             "mmc dev 0 &&"                                                  
> \
> +             "ext2load mmc 0:1 ${kernel_addr} /boot/Image && "               
> \
> +             "ext2load mmc 0:1 ${fdt_addr_base} /boot/DeveloperBox.dtb && "  
> \
> +             "setenv fdt_addr ${fdt_addr_base} &&"                           
> \
> +             "setenv fdt_size ${filesize} &&"                                
> \
> +             "setenv bootargs ${mmc_bootargs1} && "                          
> \
> +             "booti ${kernel_addr} - ${fdt_addr}\0"                          
> \
> +     "mmc_bootargs1="                                                        
> \
> +             "root=/dev/mmcblk0p1 rw dtb=0x${fdt_addr},0x${fdt_size} "       
> \
> +             "${basic_bootargs} \0"

You are strongly encouraged to use the generic distro boot features
instead.  This may require a little work to handle the device tree.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to