On Sat, 17 Apr 2021 09:20:59 -0500 Samuel Holland <[email protected]> wrote:
> Pine H64 and Orange Pi 3 both provide a USB3 type A port. > Enable it in U-Boot. Any reason to enable it only for those two boards? Just because those are the H6 devices you have access to? I wonder if we should enable this in Kconfig for all H6 boards? Or at least reduce the number of lines in defconfig, by adding select's in Kconfig? Also: this doesn't work out of the box for the Pine H64, right? Because the official DT keeps the dwc3 and usb3phy nodes disabled. I was planing on sending a DT fix to the kernel. But with those nodes enabled it indeed works for me, and adds another usable USB port to those H6 boards. Cheers, Andre > > Signed-off-by: Samuel Holland <[email protected]> > --- > configs/orangepi_3_defconfig | 5 +++++ > configs/pine_h64_defconfig | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/configs/orangepi_3_defconfig b/configs/orangepi_3_defconfig > index 82b9815205..eb25bd9f50 100644 > --- a/configs/orangepi_3_defconfig > +++ b/configs/orangepi_3_defconfig > @@ -8,5 +8,10 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5" > CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-3" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > +CONFIG_PHY_SUN50I_USB3=y > +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_DWC3=y > +# CONFIG_USB_DWC3_GADGET is not set > diff --git a/configs/pine_h64_defconfig b/configs/pine_h64_defconfig > index 2fa66f3834..0095fb222e 100644 > --- a/configs/pine_h64_defconfig > +++ b/configs/pine_h64_defconfig > @@ -12,5 +12,10 @@ CONFIG_SPL_SPI_SUNXI=y > CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-pine-h64" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SUN8I_EMAC=y > +CONFIG_PHY_SUN50I_USB3=y > +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_DWC3=y > +# CONFIG_USB_DWC3_GADGET is not set
