Dear Stefano Babic, In message <[email protected]> you wrote: > Last commit 3831530dcb7b71329c272ccd6181f8038b6a6dd0a was intended > "explicitly specify FAT12/16 root directory parsing buffer size, instead > of relying on cluster size". Howver, the underlying function requires > the size of the buffer in blocks, not in bytes, and instead of passing > a double sector size a request for 1024 blocks is sent. This generates > a buffer overflow with overwriting of other structure (in the case seen, > USB structures were overwritten). > > Signed-off-by: Stefano Babic <[email protected]> > CC: Mikhail Zolotaryov <[email protected]> > > --- > fs/fat/fat.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)
Nice catch! Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Never worry about theory as long as the machinery does what it's supposed to do. - R. A. Heinlein _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
