On Fri, Apr 23, 2021 at 04:50:21PM +0900, AKASHI Takahiro wrote: > On Fri, Apr 23, 2021 at 10:21:52AM +0300, Ilias Apalodimas wrote: > > Akashi-san > > > > [...] > > > 7) Pytest is broken > > > Due to your and Ilias' recent patches, existing pytests for > > > secure boot as well as capsule update are now broken. > > > I'm not sure why you have not yet noticed. > > > Presumably, Travis CI now skips those tests? > > > > I can have a look on that. Any idea which part is broken exactly? > > the efidebug command just added an option for 'efidebug boot add'. Did I > > forget to change any of the python scripts? > > Yes, you did :) >
Ah great my grep failed me then! > You introduced "-s" for possible options to "efidebug boot add". > So any of executions of this command in either secure boot or > capsule update test fails now. Indeed -b was added for thge boot options and -s for the optional data. You don't have to look at this, I'll reproduce it and send whatever patches are needed. Thanks! /Ilias > > -Takahiro Akashi > > > Thanks > > /Ilias > > > > > > If I have some time in the future, I will address them. > > > But Sughosh can do as well. > > > > > > -Takahiro Akashi