On Thu, Apr 22, 2021 at 09:44:18AM +0200, Rasmus Villemoes wrote:
> When CONFIG_USE_DEFAULT_ENV_FILE=y and the file
> CONFIG_DEFAULT_ENV_FILE is empty (or at least doesn't contain any
> non-comment, non-empty lines), we end up feeding nothing into xxd,
> which in turn then outputs nothing. Then blindly appending ", 0x00"
> means that we end up trying to compile (roughly)
>
> const char defaultenv[] = { , 0x00 }
>
> which is of course broken.
>
> To fix that, change the frobbing of the text file so that we always
> end up printing an extra empty line (which gets turned into that extra
> nul byte we need) - that corresponds better to the binary format
> consisting of a series of key=val nul terminated strings, terminated
> by an empty string.
>
> Reported-by: Oleksandr Suvorov <oleksandr.suvo...@toradex.com>
> Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvo...@toradex.com>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
