Hi Simon,
On Tue, May 11, 2021 at 12:28 AM Simon Glass <[email protected]> wrote:
>
> Hi Bin,
>
> On Mon, 10 May 2021 at 06:24, Bin Meng <[email protected]> wrote:
> >
> > Generally speaking BINMAN_FDT makes sense for OF_SEPARATE or OF_EMBED.
> > For the other OF_CONTROL methods, it's quite possible binman node is
> > not available as binman is invoked during the build phase instead of
> > runtime. Let's only turn it on for OF_SEPARATE or OF_EMBED by default.
> >
> > Signed-off-by: Bin Meng <[email protected]>
> >
> > ---
> >
> > (no changes since v3)
> >
> > Changes in v3:
> > - new patch: "lib: kconfig: Limit BINMAN_FDT for OF_SEPARATE or OF_EMBED"
> >
> > lib/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I think you need to handle the sandbox case too - OF_HOSTFILE
Ah, that's odd :)
Or maybe we should just ignore the -ENOENT error and return 0 in
binman_init(), instead of changing the Kconfig?
ret = find_image_node(&binman->image);
if (ret)
return 0;
What do you think?
>
> Perhaps we don't have tests for this? I need to add some.
Regards,
Bin
