On Sat, May 15, 2021 at 11:07:44PM +0300, Ramon Fried wrote: > On Wed, May 12, 2021 at 11:03 AM Tero Kristo <[email protected]> wrote: > > > > TFTP transfer size can be used to re-size the TFTP progress bar on > > single line based on the server reported file size. The support for > > this has been around from 2019, but it was never converted to proper > > Kconfig. > > > > While adding this new Kconfig, enable it by default for OMAP2+ and K3 > > devices also. > > > > Signed-off-by: Tero Kristo <[email protected]> > > --- > > v2: convert to proper Kconfig and add defaults for TI platforms > > > > net/Kconfig | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/net/Kconfig b/net/Kconfig > > index c4b4dae064..ba0ca813ce 100644 > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -74,6 +74,17 @@ config TFTP_WINDOWSIZE > > before an ack response is required. > > The default TFTP implementation implies a window size of 1. > > > > +config TFTP_TSIZE > > + bool "Track TFTP transfers based on file size option" > > + depends on CMD_TFTPBOOT > > + default y if (ARCH_OMAP2PLUS || ARCH_K3) > > + help > > + By default, TFTP progress bar is increased for each received UDP > > + frame, which can lead into long time being spent for sending > > + data over the UART. Enabling this option, TFTP queries the file > > + size from server, and if supported, limits the progress bar to > > + 50 characters total which fits on single line. > > + > > config SERVERIP_FROM_PROXYDHCP > > bool "Get serverip value from Proxy DHCP response" > > help > > -- > > 2.17.1 > > > Very good, > Two remarks, please use tools/moveconfig.py in order to automatically > move all defconfigs into the configuration you just created.
It's nice when that's done, but honestly not a big deal since it also tends to lead to making the patch harder to merge due to merge conflicts. > Second, don't add default here for the specific boards. add the option > on the board specific Kconfig. I prefer them to be here, rather than in the board Kconfig files as that second option makes more churn in the defconfig files I believe on resyncs. -- Tom
signature.asc
Description: PGP signature
