Re: [PATCHv4 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

[Kever Yang]

On 2021/6/5 下午10:38, Anand Moon wrote:

Use the generic error number instead of specific error number.
Changes fix the below error.

drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read':
drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_UNSUPPORTED'
                         undeclared (first use in this function)
    70 |   return PCIBIOS_UNSUPPORTED;
       |          ^~~~~~~~~~~~~~~~~~~
drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_write':
drivers/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED'
                         undeclared (first use in this function)
    90 |   return PCIBIOS_UNSUPPORTED;
       |          ^~~~~~~~~~~~~~~~~~~

Cc: Patrick Wildt <patr...@blueri.se>
Cc: Neil Armstrong <narmstr...@baylibre.com>
Cc: Kever Yang <kever.y...@rock-chips.com>
Reviewed-by: Neil Armstrong <narmstr...@baylibre.com>
Reviewed-by: Patrick Wildt <patr...@blueri.se>
Signed-off-by: Anand Moon <linux.am...@gmail.com>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
  drivers/pci/pcie_dw_rockchip.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
index bc22af4230..3ac2434b69 100644
--- a/drivers/pci/pcie_dw_rockchip.c
+++ b/drivers/pci/pcie_dw_rockchip.c
@@ -67,7 +67,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 
*val)
  {
        if ((uintptr_t)addr & (size - 1)) {
                *val = 0;
-               return PCIBIOS_UNSUPPORTED;
+               return -EOPNOTSUPP;
        }

if (size == 4) {

@@ -87,7 +87,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 
*val)
  static int rk_pcie_write(void __iomem *addr, int size, u32 val)
  {
        if ((uintptr_t)addr & (size - 1))
-               return PCIBIOS_UNSUPPORTED;
+               return -EOPNOTSUPP;

if (size == 4)

                writel(val, addr);