On Wed, 16 Jun 2021 10:33:26 +0800 [email protected] ([email protected]) wrote:
Hi, > From: qianfan Zhao <[email protected]> > > Since the usb otg driver support R40 device, we enable usb gadget > functions and ums. > > Signed-off-by: qianfan Zhao <[email protected]> > --- > configs/Bananapi_M2_Ultra_defconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configs/Bananapi_M2_Ultra_defconfig > b/configs/Bananapi_M2_Ultra_defconfig > index 37bcb3d7bf..a0869d56ae 100644 > --- a/configs/Bananapi_M2_Ultra_defconfig > +++ b/configs/Bananapi_M2_Ultra_defconfig > @@ -7,12 +7,13 @@ CONFIG_MACPWR="PA17" > CONFIG_MMC0_CD_PIN="PH13" > CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > CONFIG_USB1_VBUS_PIN="PH23" > -CONFIG_USB2_VBUS_PIN="PH23" > CONFIG_DEFAULT_DEVICE_TREE="sun8i-r40-bananapi-m2-ultra" > CONFIG_AHCI=y > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SPL_I2C_SUPPORT=y > +CONFIG_CMD_USB_MASS_STORAGE=y So in general we don't have those kind of command enables in the defconfig. It might be worth discussing whether we should enable the really useful "ums" command by default, for all Allwinner devices enabling USB gadget mode, but this would be done differently. > CONFIG_SCSI_AHCI=y > +# CONFIG_USB_FUNCTION_FASTBOOT is not set Why is this explicitly disabled? From what I can see, it doesn't hurt to leave it enabled (through Kconfig's default), it does not interfere with other gadgets like UMS or Ethernet. > CONFIG_RGMII=y > CONFIG_SUN8I_EMAC=y > CONFIG_AXP_DLDO4_VOLT=2500 > @@ -20,3 +21,5 @@ CONFIG_AXP_ELDO3_VOLT=1200 > CONFIG_SCSI=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_MUSB_GADGET=y > +CONFIG_USB_GADGET_DOWNLOAD=y This last symbol is enabled automatically by the FASTBOOT option. Cheers, Andre
