Hi Stefan, On Thu, Jul 1, 2021 at 1:22 AM Stefan Roese <[email protected]> wrote: > > Hi Tony, > > On 01.07.21 10:19, Stefan Roese wrote: > > On 01.07.21 06:26, Tony Dinh wrote: > >> In DM Ethernet, the old "egiga0" name is no longer valid, so replace it > >> with Ethernet PHY name from device tree. > >> > >> Signed-off-by: Tony Dinh <[email protected]> > >> --- > >> > >> board/zyxel/nsa310s/nsa310s.c | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/board/zyxel/nsa310s/nsa310s.c > >> b/board/zyxel/nsa310s/nsa310s.c > >> index cd4a7723b1..29aded1910 100644 > >> --- a/board/zyxel/nsa310s/nsa310s.c > >> +++ b/board/zyxel/nsa310s/nsa310s.c > >> @@ -1,5 +1,6 @@ > >> // SPDX-License-Identifier: GPL-2.0+ > >> /* > >> + * Copyright (C) 2021 Tony Dinh <[email protected]> > > > > AFAIU, just changing a few lines, as this patch does, does not justify > > to add a copyright notice to this file. > > I just noticed that you already are present in the copyright notice > below. I suggest to change this in a way, so that your name only > occurs once, like: > > * Copyright (C) 2015, 2021 Tony Dinh <[email protected]> > > Does this make sense?
Definitely! I will correct the copyright for this patch and also the copyright in patch 4/4 using this convention. > > Thanks, > Stefan > > >> * Copyright (C) 2015 > >> * Gerald Kerma <[email protected]> > >> * Tony Dinh <[email protected]> > >> @@ -81,22 +82,18 @@ int board_init(void) > >> return 0; > >> } > >> +#define PHY_ADR 1 > > > > You should be able to read this PHY address from the device-tree now. > > No need to define this here again. I don't know yet how to extract this info from the device tree nodes (I am familiar with this in Linux kernel, but at first glance it seems like u-boot fdt library is different). So if it is OK, perhaps I could send in another patch for this correction after this DM conversion is done. Thanks, Tony
