From: Pali Rohár <p...@kernel.org>

Too small invalid headers may cause kwboot to crash.
Check for header size of v1 images.

Signed-off-by: Pali Rohár <p...@kernel.org>
Reviewed-by: Marek Behún <marek.be...@nic.cz>
Reviewed-by: Stefan Roese <s...@denx.de>
Reviewed-by: Chris Packham <judge.pack...@gmail.com>
Tested-by: Chris Packham <judge.pack...@gmail.com>
---
 tools/kwboot.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/kwboot.c b/tools/kwboot.c
index c0ac4ce19e..1d32c1b7ad 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -645,6 +645,11 @@ kwboot_img_patch_hdr(void *img, size_t size)
        else
                hdrsz = KWBHEADER_V1_SIZE(hdr);
 
+       if (size < hdrsz) {
+               errno = EINVAL;
+               goto out;
+       }
+
        csum = kwboot_img_csum8(hdr, hdrsz) - hdr->checksum;
        if (csum != hdr->checksum) {
                errno = EINVAL;
-- 
2.31.1

Reply via email to