Dear Roy Zang, In message <[email protected]> you wrote: > This patch adds general CodeWarrior debug support. > Patch is tested on 85xx/QorIQ platforms in u-boot. > CONFIG_DEBUG_CODEWARRIOR should be defined if the u-boot needs to be > debugged by CodeWarrior. > To use the CodeWarrior debug funciton, the make command can be just as > make CONFIG_DEBUG_CODEWARRIOR=1
I don't like that approach, for a number of reasons. First, I don't want to see the code sprinkled with a growing list of CONFIG_DEBUG_CODEWARRIOR, CONFIG_DEBUG_BDI, CONFIG_DEBUG_PEEDIE, CONFIG_DEBUG_TRACE32, CONFIG_DEBUG_OCD, CONFIG_DEBUG_CORELIS, ... defines. What in your additions is actually specific to the CW debugger? > config.mk | 8 ++++++++ Second, I understand that this has been tested with and is intended for (a certain class of) Power Architecture systems only. Then why do you add it to the top level Makefile? > +ifdef CONFIG_DEBUG_CODEWARRIOR > +CFLAGS += -ggdb > +endif Are you sure that CFLAGS is OK here? I would expect to see this with PLATFORM_CPPFLAGS instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Minds are like parachutes - they only function when open. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
