Hi Dave, On 8/11/21 12:12 AM, Lokesh Vutla wrote: > > > On 11/08/21 1:19 am, Dave Gerlach wrote: >> Add a note to the automatically generated clk-data and dev-data files >> for j721e and j7200 to indicate that they are in fact auto-generated and >> should not be hand edited. >> >> Signed-off-by: Dave Gerlach <d-gerl...@ti.com> > > Are there any guidelines/README to do this autogeneration?
And if these are not going to be public, I suggest you rephrase the below sentence to something like "This file is auto generated. Please report any issues to <contact>". > > Thanks and regards, > Lokesh > >> --- >> arch/arm/mach-k3/j7200/clk-data.c | 2 ++ >> arch/arm/mach-k3/j7200/dev-data.c | 2 ++ >> arch/arm/mach-k3/j721e/clk-data.c | 2 ++ >> arch/arm/mach-k3/j721e/dev-data.c | 2 ++ >> 4 files changed, 8 insertions(+) >> >> diff --git a/arch/arm/mach-k3/j7200/clk-data.c >> b/arch/arm/mach-k3/j7200/clk-data.c >> index 49145bbfc8cd..649d28b1db0b 100644 >> --- a/arch/arm/mach-k3/j7200/clk-data.c >> +++ b/arch/arm/mach-k3/j7200/clk-data.c >> @@ -2,6 +2,8 @@ >> /* >> * J7200 specific clock platform data >> * >> + * This file is auto generated. Please do not edit directly. >> + * >> * Copyright (C) 2020-2021 Texas Instruments Incorporated - >> http://www.ti.com/ Btw, while you are at this, can we get all of these links to be updated to use https:// >> */ I also prefer a blank line between the license comments and the first header inclusion. regards Suman >> #include "k3-clk.h" >> diff --git a/arch/arm/mach-k3/j7200/dev-data.c >> b/arch/arm/mach-k3/j7200/dev-data.c >> index c68bcc58e9a7..f7b7892da97b 100644 >> --- a/arch/arm/mach-k3/j7200/dev-data.c >> +++ b/arch/arm/mach-k3/j7200/dev-data.c >> @@ -2,6 +2,8 @@ >> /* >> * J7200 specific device platform data >> * >> + * This file is auto generated. Please do not edit directly. >> + * >> * Copyright (C) 2020-2021 Texas Instruments Incorporated - >> http://www.ti.com/ >> */ >> #include "k3-dev.h" >> diff --git a/arch/arm/mach-k3/j721e/clk-data.c >> b/arch/arm/mach-k3/j721e/clk-data.c >> index ff9262d7bcee..aa3f50a02f59 100644 >> --- a/arch/arm/mach-k3/j721e/clk-data.c >> +++ b/arch/arm/mach-k3/j721e/clk-data.c >> @@ -2,6 +2,8 @@ >> /* >> * J721E specific clock platform data >> * >> + * This file is auto generated. Please do not edit directly. >> + * >> * Copyright (C) 2020-2021 Texas Instruments Incorporated - >> http://www.ti.com/ >> */ >> #include "k3-clk.h" >> diff --git a/arch/arm/mach-k3/j721e/dev-data.c >> b/arch/arm/mach-k3/j721e/dev-data.c >> index 96393c713278..a8bc6ce20d1d 100644 >> --- a/arch/arm/mach-k3/j721e/dev-data.c >> +++ b/arch/arm/mach-k3/j721e/dev-data.c >> @@ -2,6 +2,8 @@ >> /* >> * J721E specific device platform data >> * >> + * This file is auto generated. Please do not edit directly. >> + * >> * Copyright (C) 2020-2021 Texas Instruments Incorporated - >> http://www.ti.com/ >> */ >> #include "k3-dev.h" >>