Hi Wolfgang, On Friday 29 October 2010 22:54:04 Wolfgang Denk wrote: > > + buff = malloc(UBIFS_BLOCK_SIZE); > > + > > + /* Read block-siez into temp buffer */ > > + ret = read_block(inode, buff, block, dn); > > + if (last_block_size) > > + dlen = last_block_size; > > + else > > + dlen = le32_to_cpu(dn->size); > > How about some error handling? > > malloc() can fail, and read_block() can fail as well.
Right. I'll change this and send an updated version. Thanks for the review. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: [email protected]
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
