Hi Oleksandr,

On Tue, Aug 31, 2021 at 1:42 PM Oleksandr Suvorov
<[email protected]> wrote:
>
> Import HS400 support for iMX7ULP B0 from the Linux kernel:
>
> 2eaf5a533afd ("mmc: sdhci-esdhc-imx: Add HS400 support for iMX7ULP")
>
> According to IC suggest, need to clear the STROBE_DLL_CTRL_RESET
> before any setting of STROBE_DLL_CTRL register.
>
> USDHC has register bits(bit[27~20] of register STROBE_DLL_CTRL)
> for slave sel value. If this register bits value is 0,  it needs
> 256 ref_clk cycles to update slave sel value. IC suggest to set
> bit[27~20] to 0x4, it only need 4 ref_clk cycle to update slave
> sel value. This will short the lock time of slave.
>
> i.MX7ULP B0 will need more time to lock the REF and SLV, so change
> to add 5us delay.
>
> Signed-off-by: Oleksandr Suvorov <[email protected]>
> Series-notes
> fsl_esdhc_imx improvements
>
> Import individual settings for soc imx7ulp and add support of HS400 for
> this soc.
> END

The text below the Signed-off-by should be removed.

Other than that, the patch looks good:

Reviewed-by: Fabio Estevam <[email protected]>

Reply via email to