On 11/03/2010 03:59 AM, Renato Frias wrote: > From: Renato Frias <[email protected]> > > Adds video support to mx51evk board, this board allows different displays. > This patch enables the WVGA TFT LCD panel only, on Display interface 1. > Remove comments from include/configs/mx51evk.h to use it.
Last line does not apply for the commit message. This is only a change from your V1 patch, because the mx51evk.h in mainline has no commented configuration. > + > +static int wvga_ipu_di = 1; > +static int wvga_bppix = 16; Why do you set these variables as you need only in lcd_enable() ? > +/* > + * Framebuffer and LCD > + */ > +/* You say you removed the comment, but it seems you have not.... Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
