On Tue, Sep 14, 2021 at 03:53:33PM -0500, Alexandru Gagniuc wrote:
> The hash algorithm selection was streamlined in commit 92055e138f28
> ("image: Drop if/elseif hash selection in calculate_hash()"). Said
> commit kept the call to cpu_to_uimage() to convert the CRC to big
> endian format.
>
> This would have been correct when calling crc32_wd(). However, the
> ->hash_func_ws member of crc32 points to crc32_wd_buf(), which already
> converts the CRC to big endian. On a little endian host, doing both
> conversions results in a little-endian CRC. This is incorrect.
>
> To remedy this, simply drop the call to cpu_to_uimage(), thus only
> doing the byte-order conversion once.
>
> Fixes: 92055e138f28 ("image: Drop if/elseif hash selection in
> calculate_hash()")
> Tested-by: Tom Rini <[email protected]>
> Signed-off-by: Alexandru Gagniuc <[email protected]>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
