Hi Patrick
On 9/14/21 2:31 PM, Patrick Delaunay wrote:
> The vbus-supply is an optional property of sub-node connector node.
> and no more in the usb phyc node (in first proposed binding).
>
> This regulator for USB VBUS may be needed for host mode.
>
> See the latest kernel binding for details in
> Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml.
>
> usbphyc_port0: usb-phy@0 {
> reg = <0>;
> phy-supply = <&vdd_usb>;
> #phy-cells = <0>;
> connector {
> compatible = "usb-a-connector";
> vbus-supply = <&vbus_sw>;
> };
> };
>
> Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com>
> ---
>
> drivers/phy/phy-stm32-usbphyc.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c
> index 02d859a039..c206efd28d 100644
> --- a/drivers/phy/phy-stm32-usbphyc.c
> +++ b/drivers/phy/phy-stm32-usbphyc.c
> @@ -339,7 +339,7 @@ static int stm32_usbphyc_probe(struct udevice *dev)
> {
> struct stm32_usbphyc *usbphyc = dev_get_priv(dev);
> struct reset_ctl reset;
> - ofnode node;
> + ofnode node, connector;
> int i, ret;
>
> usbphyc->base = dev_read_addr(dev);
> @@ -395,10 +395,12 @@ static int stm32_usbphyc_probe(struct udevice *dev)
> return ret;
> }
>
> - ret = stm32_usbphyc_get_regulator(node, "vbus-supply",
> - &usbphyc_phy->vbus);
> - if (ret)
> - usbphyc_phy->vbus = NULL;
> + usbphyc_phy->vbus = NULL;
> + connector = ofnode_find_subnode(node, "connector");
> + if (ofnode_valid(connector)) {
> + ret = stm32_usbphyc_get_regulator(connector,
> "vbus-supply",
> + &usbphyc_phy->vbus);
> + }
>
> node = dev_read_next_subnode(node);
> }
>
Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com>
Thanks
Patrice
