On Fri, Sep 17, 2021 at 11:49:51AM +0000, T Karthik Reddy wrote: > Hi Tom, > > > -----Original Message----- > > From: Tom Rini <tr...@konsulko.com> > > Sent: Thursday, August 5, 2021 6:53 PM > > To: T Karthik Reddy <tkart...@xilinx.com> > > Cc: Ashok Reddy Soma <ashok...@xilinx.com>; u-boot@lists.denx.de; > > miquel.ray...@bootlin.com; git <g...@xilinx.com> > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable > > > > On Thu, Aug 05, 2021 at 05:56:50AM +0000, T Karthik Reddy wrote: > > > Hello Tom Rini, > > > > > > > -----Original Message----- > > > > From: Tom Rini <tr...@konsulko.com> > > > > Sent: Wednesday, August 4, 2021 8:52 PM > > > > To: Ashok Reddy Soma <ashok...@xilinx.com> > > > > Cc: u-boot@lists.denx.de; miquel.ray...@bootlin.com; git > > > > <g...@xilinx.com>; T Karthik Reddy <tkart...@xilinx.com> > > > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env > > > > variable > > > > > > > > On Fri, Jul 23, 2021 at 06:18:26AM -0600, Ashok Reddy Soma wrote: > > > > > > > > > From: T Karthik Reddy <t.karthik.re...@xilinx.com> > > > > > > > > > > Tpm test cases relies on tpm device setup. Provide an environment > > > > > variable "env__tpm_device_test_skip = True" to skip the test case > > > > > if tpm device is not present. > > > > > Only needed will have to add variable to the py-test framework. > > > > > Test runs successfully even this variable is absent. > > > > > > > > > > Signed-off-by: T Karthik Reddy <t.karthik.re...@xilinx.com> > > > > > Signed-off-by: Ashok Reddy Soma <ashok.reddy.s...@xilinx.com> > > > > > > > > Why is this not using boardenv_* like other tests do to disable running? > > > > > > What I meant here was this test doesn't depend on configuration value > > > from boardenv_*. But it uses env__tpm_device_test_skip variable from > > the configuration file. > > > I referred test/py/tests/test_sleep.py for writing this test case, hence > > copied comments as well. > > > Should I change this NOTE in comment section? > > > > Thanks for explaining. This got me to re-read the existing tests and while > > none of it is as clear as I would like, your example here is just as clear > > as the > > rest, so it's fine and I'll pick it up soon. > > I see this patch is not yet applied on the repo, could you please let me know > when this will be applied?
Ilias, since you've said you'd review TPM related patches, does this: https://patchwork.ozlabs.org/project/uboot/patch/1624340962-91190-1-git-send-email-t.karthik.re...@xilinx.com/ work for you? Thanks. -- Tom
signature.asc
Description: PGP signature
