Dear Adam, In message <CAHCN7x+_3iZtTjL9i0QL=w-iLC3imegNH38Q=RyT6wz7=ov...@mail.gmail.com> you wrote: > > > > > > commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for > > > SOM-LV Boards" added (among other things) these lines: > > > > > > ... > > > 243 MUX_VAL(CP(MCSPI2_SOMI), (IEN | PTD | DIS | M0)); > > > /*HSUSB2_DATA5*/ > > > 244 MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN | M0)); > > > /*HSUSB2_DATA6*/ > > > 245 MUX_VAL(CP(MCSPI2_CLK), (IEN | PTD | DIS | M0)); > > > /*HSUSB2_DATA7*/ > > > 246 MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* > > > GPIO_4 */ > > > 247 MUX_VAL(CP(ETK_D10_ES2), (IDIS | PTU | DIS | M3)); > > > /*HSUSB2_CLK*/ > > > 248 MUX_VAL(CP(ETK_D11_ES2), (IDIS | PTU | DIS | M3)); > > > /*HSUSB2_STP*/ > > > 249 MUX_VAL(CP(ETK_D12_ES2), (IEN | PTU | DIS | M3)); > > > /*HSUSB2_DIR*/ > > > ... > > > > > > All the entries in set_muxconf_regs() have a terminating semicolon - > > > all except the entry in line # 246. > > > > > > I reckon this is a mistake and should be fixed? > > > > Interesting. MUX_VAL is from arch/arm/include/asm/arch-omap3/mux.h and > > includes a semicolon, so that's how this didn't trip anything up. Most > > of the time it's not used with one either, from a quick grep. > > I am guessing it was left out by accident. I would not have > intentionally done that. I can submit a patch to make it consistent > if you want.
Yes, it should be made xonsistent, please - otherwise everybody seeing this wonders what is going on here. Tom says there is already a semicolon in the macro and most use cases don;t have one, so the fix should probably be to keep that line and remove the other semicolons ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] The human race is faced with a cruel choice: work or daytime tele- vision.
