On 25/09/21 07:33PM, Marek Behún wrote: > From: Marek Behún <[email protected]> > > This check is already done in mtdcore's mtd_erase(), no reason to do > this here as well.
But do we always get here via mtd_erase()? What about "sf erase"? I looked at the code and I don't see any checks for 0 length there. > > Signed-off-by: Marek Behún <[email protected]> > Reviewed-by: Simon Glass <[email protected]> > Tested-by: Masami Hiramatsu <[email protected]> > --- > drivers/mtd/spi/spi-nor-core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c > index 9e936cbe1a..211eea22a4 100644 > --- a/drivers/mtd/spi/spi-nor-core.c > +++ b/drivers/mtd/spi/spi-nor-core.c > @@ -912,9 +912,6 @@ static int spi_nor_erase(struct mtd_info *mtd, struct > erase_info *instr) > dev_dbg(nor->dev, "at 0x%llx, len %lld\n", (long long)instr->addr, > (long long)instr->len); > > - if (!instr->len) > - return 0; > - > div_u64_rem(instr->len, mtd->erasesize, &rem); > if (rem) > return -EINVAL; > -- > 2.32.0 > -- Regards, Pratyush Yadav Texas Instruments Inc.
