On Wed, 13 Oct 2021 at 09:46, Marek Behún <[email protected]> wrote: > > From: Marek Behún <[email protected]> > > This function is a relic from the past when environment was read from > underlying device one character at a time. > > It is used only in the case when getting an environemnt variable prior > relocation, and the function is simple enough to be inlined there. > > Since env_get_char() is being changed to simple access to an array, we > can drop the failing cases and simplify the code (this could have been > done before, since env_get_char() did not fail even before). > > Signed-off-by: Marek Behún <[email protected]> > --- > cmd/nvedit.c | 28 ++++++++++++++-------------- > env/env.c | 8 -------- > env/nowhere.c | 5 ++--- > include/env.h | 10 ---------- > 4 files changed, 16 insertions(+), 35 deletions(-) >
in subject: typo it's should be its Reviewed-by: Simon Glass <[email protected]>
