Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

[Mathew McBride]

On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote:
> Hi Matthew,
> 
> On Thu, 4 Nov 2021 at 03:14, Mathew McBride <m...@traverse.com.au> wrote:
> 
> >  static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size)
> >  {
> > -       return 0;
> > +       if (size < 50)
> > +               return -ENOSPC;
> > +
> > +       return snprintf(buf, size, "Atmel 1.2 TPM (%s)", dev->name);
> 
> Is there anything more helpful we can print on that? Device ID,
> manufacturer ID maybe?
Perhaps the DT compatible would be useful?

=> tpm device
device 0: atmel,at97sc3204t TPM 1.2 (tpm@29)

tpm_version under Linux provides this, but it requires talking to the TPM over 
TIS:
$ tpm_version
TPM 1.2 Version Info:
  Chip Version:        1.2.66.16
  Spec Level:          2
  Errata Revision:     3
  TPM Vendor ID:       ATML
  TPM Version:         01010000
  Manufacturer Info:   41544d4c

> 
> Regards
> /Ilias
> >  }
> >
> >  /*
> > --
> > 2.30.1
> >
>