On Thu, Nov 18, 2021 at 09:29:51AM +0100, Michael Walle wrote: > Am 2021-11-17 19:24, schrieb Tom Rini: > > On Wed, Nov 17, 2021 at 05:45:58PM +0100, Michael Walle wrote: > > > Am 2021-11-16 22:14, schrieb Tom Rini: > > > > On Mon, Nov 15, 2021 at 11:45:51PM +0100, Michael Walle wrote: > > > > > > > > > Nowadays, u-boot (when CONFIG_NET_RANDOM_ETHADDR is set) will set > > > > > enetaddr to a random value if not set and then pass the randomly > > > > > generated MAC address to linux. > > > > > > > > First, for clarity I'm not nak'ing this. I kind of would like to see a > > > > slight reword as I think some things aren't 100% correct, even if the > > > > "save random MAC to ethaddr environment variable" change goes in. For > > > > example, it's quite long standing that (dev|pdata)->enetaddr populates > > > > "mac-address" and "local-mac-address" and it seems in some older cases > > > > we only set the "local-mac-address" property. > > > > > > fdt_fixup_memory() in common/fdt_support.c does a env_get(mac). > > > > Whoops, yes, I misrecalled this. > > That means you are fine with this commit message?
Well, so long as it goes in after the change that makes NET_RANDOM_ETHADDR update the environment, yes, it's all correct. -- Tom
signature.asc
Description: PGP signature