Hi Patrick
On 10/11/21 9:52 AM, Patrick Delaunay wrote: > Currently the upper OTP (after 57) are shadowed in U-Boot proper, > when TFABOOT is not used. > > This choice cause an issue when U-Boot is not executed after SPL, > so this BSEC initialization is moved in SPL and no more executed in U-Boot, > so it is still executed only one time. > > After this patch this BSEC initialization is done in FSBL: SPL or TF-A. > > To force this initialization in all the case, the probe of the BSEC > driver is forced in SPL in the arch st32mp function: spl_board_init(). > > Even if today BSEC driver is already probed in STM32MP15x clock driver > clk_stm32mp1.c because get_cpu_type() is called in > stm32mp1_get_max_opp_freq() function. > > Reported-by: Alexandru Gagniuc <mr.nuke...@gmail.com> > Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com> > --- > It is updated version of proposed Alexandru patch: > > [v2,06/11] arm: stm32mp: bsec: Update OTP shadow registers in SPL > http://patchwork.ozlabs.org/project/uboot/patch/20210907235933.2798330-7-mr.nuke...@gmail.com/ > > > arch/arm/mach-stm32mp/bsec.c | 5 ++--- > arch/arm/mach-stm32mp/cpu.c | 8 ++++++++ > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c > index fe39bd80cf..e517acdd01 100644 > --- a/arch/arm/mach-stm32mp/bsec.c > +++ b/arch/arm/mach-stm32mp/bsec.c > @@ -503,10 +503,9 @@ static int stm32mp_bsec_probe(struct udevice *dev) > > /* > * update unlocked shadow for OTP cleared by the rom code > - * only executed in U-Boot proper when TF-A is not used > + * only executed in SPL, it is done in TF-A for TFABOOT > */ > - > - if (!IS_ENABLED(CONFIG_TFABOOT) && !IS_ENABLED(CONFIG_SPL_BUILD)) { > + if (IS_ENABLED(CONFIG_SPL_BUILD)) { > plat = dev_get_plat(dev); > > for (otp = 57; otp <= BSEC_OTP_MAX_VALUE; otp++) > diff --git a/arch/arm/mach-stm32mp/cpu.c b/arch/arm/mach-stm32mp/cpu.c > index eb79f3ffd2..0263ffe96a 100644 > --- a/arch/arm/mach-stm32mp/cpu.c > +++ b/arch/arm/mach-stm32mp/cpu.c > @@ -174,7 +174,15 @@ static void dbgmcu_init(void) > > void spl_board_init(void) > { > + struct udevice *dev; > + int ret; > + > dbgmcu_init(); > + > + /* force probe of BSEC driver to shadow the upper OTP */ > + ret = uclass_get_device_by_driver(UCLASS_MISC, > DM_DRIVER_GET(stm32mp_bsec), &dev); > + if (ret) > + log_warning("BSEC probe failed: %d\n", ret); > } > #endif /* !defined(CONFIG_SPL) || defined(CONFIG_SPL_BUILD) */ > > Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com> Thanks Patrice
