2010/11/17 Stefano Babic <[email protected]>: > On 11/16/2010 09:41 AM, Jason Liu wrote: > > Hi Jason, > >> fix saveenv or env save command not work on mx51evk board. >> with this patch, we can use savenv or env save to >> store enviroments to mmc card slot 0 > >> >> -#define CONFIG_ENV_SECT_SIZE (128 * 1024) >> -#define CONFIG_ENV_SIZE CONFIG_ENV_SECT_SIZE >> -#define CONFIG_ENV_IS_NOWHERE >> +#define CONFIG_ENV_OFFSET (6 * 64 * 1024) >> +#define CONFIG_ENV_SIZE (2 * 64 * 1024) >> +#define CONFIG_ENV_IS_IN_MMC >> +#define CONFIG_SYS_MMC_ENV_DEV 0 > > Why do we need 128KB to save the environment in case of MMC ? It seems > to me too much, because we are not constrained to the sector size as for > flash devices.
I set it according to the following reason, - Keep the same setting as the original when you commit the mx51 support patch. Why you select 128KB? :) - As I looked through other platform such as OMAP4 for MMC ENV setting, it's also set for 128KB - Leave much room for the user to store customer env. > > Can we save some time by saving or reading the environment reducing its > size ? Or do you plan to save something more in this area ? It's always the trade-off, set to 512B or less will save some time according to 128KB, but it will face much risk to change the code frequently to meet the increasing env size requirement. what's the size do you think is suitable? > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] > ===================================================================== > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
