On Sun, 2021-12-19 at 14:20 +0000, Ivan Mikhaylov wrote: > On Sat, 2021-12-18 at 18:23 +0000, Joakim Tjernlund wrote: > > Ping? > > Maybe just revert commit 8a726b852502 ("fw_setenv: lock the flash > > only if it was locked before") ? > > > > ________________________________________ > > From: Joakim Tjernlund <joakim.tjernl...@infinera.com> > > Sent: 13 December 2021 18:22 > > To: u-boot@lists.denx.de; joe.hershber...@ni.com; fr0st6...@gmail.com > > Subject: Re: [PATCH] fw_setenv: Unbreak fw_setenv caused by buggy > > MEMISLOCKED use > > > > +Joe Hershberger > > > > Jocke > > > > On Wed, 2021-12-08 at 15:33 +0100, Joakim Tjernlund wrote: > > > Commit "fw_setenv: lock the flash only if it was locked before" > > > checks for Locked status with uninitialized erase data. > > > Address by moving the test for MEMISLOCKED. > > > > > > Fixes: 8a726b852502 ("fw_setenv: lock the flash only if it was > > > locked before") > > > Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> > > Joakim, can you provide more detailed description about what you want > to fix or revert, please? In which case you see problems with > 8a726b852502? > > Thanks. >
We see it when we set a variable to the same value it already had, then we get a locking error from fw_setenv. If you just look 1 min at the code you will see that 8a726b852502 sends garbage to MEMISLOCKED Jocke