On Sun, Dec 19, 2021 at 11:18 PM Stefan Roese <s...@denx.de> wrote: > > Hi Tony, > > On 12/18/21 22:41, Tony Dinh wrote: > > Hi Pali, > > > > On Sat, Dec 18, 2021 at 5:17 AM Pali Rohár <p...@kernel.org> wrote: > >> > >> On Friday 17 December 2021 20:23:28 Tony Dinh wrote: > >>> Add board defconfig file for Pogoplug V4 board > >>> > >>> Signed-off-by: Tony Dinh <mibo...@gmail.com> > >>> --- > >>> > >>> configs/pogo_v4_defconfig | 97 +++++++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 97 insertions(+) > >>> create mode 100644 configs/pogo_v4_defconfig > >>> > >>> diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > >>> new file mode 100644 > >>> index 0000000000..b183c9c46f > >>> --- /dev/null > >>> +++ b/configs/pogo_v4_defconfig > >>> @@ -0,0 +1,97 @@ > >>> +# SPDX-License-Identifier: GPL-2.0+ > >>> +# > >>> +# (C) Copyright 2017-2021 Tony Dinh <mibo...@gmail.com> > >>> +# > >>> +CONFIG_ARM=y > >>> +CONFIG_SKIP_LOWLEVEL_INIT=y > >>> +CONFIG_SYS_DCACHE_OFF=y > >>> +CONFIG_ARCH_CPU_INIT=y > >>> +CONFIG_SYS_THUMB_BUILD=y > >>> +CONFIG_ARCH_KIRKWOOD=y > >>> +CONFIG_SYS_TEXT_BASE=0x600000 > >>> +CONFIG_TARGET_POGO_V4=y > >>> +CONFIG_ENV_SIZE=0x20000 > >>> +CONFIG_ENV_OFFSET=0xC0000 > >>> +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-pogoplug_v4" > >>> +CONFIG_BOOTDELAY=10 > >>> +CONFIG_BOOTSTAGE=y > >>> +CONFIG_SHOW_BOOT_PROGRESS=y > >>> +CONFIG_USE_PREBOOT=y > >>> +CONFIG_HUSH_PARSER=y > >>> +CONFIG_SYS_PROMPT="Pogo_V4> " > >>> +CONFIG_IDENT_STRING="\nPogoplug V4" > >>> +CONFIG_SYS_LOAD_ADDR=0x800000 > >>> +CONFIG_VERSION_VARIABLE=y > >>> +# CONFIG_CMD_FLASH is not set > >>> +CONFIG_CMD_SETEXPR=y > >>> +CONFIG_CMD_NAND=y > >>> +CONFIG_CMD_MMC=y > >>> +CONFIG_CMD_USB=y > >>> +CONFIG_CMD_DHCP=y > >>> +CONFIG_CMD_MII=y > >>> +CONFIG_CMD_PING=y > >>> +CONFIG_CMD_EXT2=y > >>> +CONFIG_CMD_EXT4=y > >>> +CONFIG_CMD_FAT=y > >>> +CONFIG_CMD_JFFS2=y > >>> +CONFIG_CMD_FS_GENERIC=y > >>> +CONFIG_CMD_MTDPARTS=y > >>> +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:2M(u-boot),3M(uImage),3M(uImage2),8M(failsafe),112M(root)" > >>> +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand" > >>> +CONFIG_CMD_UBI=y > >>> +CONFIG_ISO_PARTITION=y > >>> +CONFIG_EFI_PARTITION=y > >>> +CONFIG_PARTITION_UUIDS=y > >>> +CONFIG_PARTITION_TYPE_GUID=y > >>> +CONFIG_ENV_OVERWRITE=y > >>> +CONFIG_ENV_IS_IN_NAND=y > >>> +CONFIG_SYS_NS16550=y > >>> +CONFIG_USB=y > >>> +CONFIG_USB_STORAGE=y > >>> +CONFIG_USB_EHCI_HCD=y > >>> +CONFIG_OF_LIBFDT=y > >>> +CONFIG_CMD_FDT=y > >>> +CONFIG_CMD_BOOTZ=y > >>> +CONFIG_NETCONSOLE=y > >>> +CONFIG_MTD=y > >>> +CONFIG_MTD_RAW_NAND=y > >>> +CONFIG_CMD_MTD=y > >>> +CONFIG_MTD_PARTITIONS=y > >>> +CONFIG_MTD_DEVICE=y > >>> +CONFIG_NET=y > >>> +CONFIG_NETDEVICES=y > >>> +CONFIG_MVGBE=y > >>> +CONFIG_MII=y > >>> +CONFIG_DM=y > >>> +CONFIG_DM_USB=y > >>> +CONFIG_OF_CONTROL=y > >>> +CONFIG_DM_ETH=y > >>> +CONFIG_NET_RANDOM_ETHADDR=y > >>> +CONFIG_BLK=y > >>> +CONFIG_CMD_SATA=y > >>> +CONFIG_SATA_MV=y > >>> +CONFIG_DM_MMC=y > >>> +CONFIG_MVEBU_MMC=y > >>> +CONFIG_CMD_PCI=y > >>> +CONFIG_PCI=y > >>> +CONFIG_PCI_MVEBU=y > >>> +CONFIG_PCI_PNP=y > >>> +CONFIG_USB_XHCI_HCD=y > >>> +CONFIG_USB_XHCI_PCI=y > >>> +CONFIG_BOARD_LATE_INIT=y > >>> +# > >>> +# RTC emulation > >>> +# > >>> +CONFIG_CMD_DATE=y > >>> +CONFIG_PROT_UDP=y > >>> +CONFIG_CMD_SNTP=y > >>> +CONFIG_CMD_DNS=y > >>> +CONFIG_DM_RTC=y > >>> +CONFIG_RTC_EMULATION=y > >>> +# > >>> +# Turn off unused capabilities to save space > >>> +# > >>> +# CONFIG_BOOTM_PLAN9 is not set > >>> +# CONFIG_BOOTM_RTEMS is not set > >>> +# CONFIG_BOOTM_VXWORKS is not set > >>> +# CONFIG_MMC_HW_PARTITIONING is not set > >>> -- > >>> 2.20.1 > >>> > >> > >> Hello! Please regenerate this defconfig file to its canonical form. You > >> can do it by commands: > >> > >> make pogo_v4_defconfig > >> make savedefconfig > >> mv defconfig configs/pogo_v4_defconfig > > > > Yes, it's a bit harder to read, but it should be done. > > It's not a matter of "harder to read". It's the only way, this file > should be generated. Otherwise this will very likely generate merge > problems when other changes might get introduced to the config files > (e.g. by using moveconfig.py).
I see. Thanks for the explanation! Tony > Thanks, > Stefan