On Thu, Dec 23, 2021 at 10:49:38PM +0100, Tommaso Merciai wrote: > On Sun, Dec 19, 2021 at 10:11:44AM +0800, Peng Fan (OSS) wrote: > > > > > > On 2021/12/1 4:17, Tommaso Merciai wrote: > > > This series move env_get_location from soc to board level. As suggested > > > by Michael <[email protected]> make no sense to define an > > > unique way for multiple board. One board can boot from emmc and having > > > env on spi flash etc.. Anyways, this function is kept in both imx8mn > > > and imx8mp evk boards instead of being completely dropped. > > > (as suggested by Andrey <[email protected]>) > > > > If there are other i.MX8MN/P boards already uses the function, move > > it to i.mx8mn/p_evk would break other boards. If i.MX8MN/P evk are > > the other users, it should be ok to move the board code. > > Hi Peng, > Maybe declare it as __weak in soc.c and ovverride it a board level can > be a valid solution? > Let me know.
Hi Peng, Reviewing env_get_location is already declared as __weak, my bad. Then we have to add it in other boards that use imx8mp/imx8mn: - board/phytec/phycore_imx8mp/phycore-imx8mp.c - board/beacon/imx8mn/imx8mn_beacon.c I will try to involve the respective maintainers and resend it in v3. Thanks, Tommaso > > > thanks. > tommaso > > > > > Regards, > > Peng. > > > > > > > > Tommaso Merciai (3): > > > imx8m: drop env_get_location for imx8mn and imx8mp > > > imx: imx8mn_evk: override env_get_location > > > imx: imx8mp_evk: override env_get_location > > > > > > arch/arm/mach-imx/imx8m/soc.c | 39 ------------------------- > > > board/freescale/imx8mn_evk/imx8mn_evk.c | 35 ++++++++++++++++++++++ > > > board/freescale/imx8mp_evk/imx8mp_evk.c | 34 +++++++++++++++++++++ > > > 3 files changed, 69 insertions(+), 39 deletions(-) > > >
